Add Buffer to args array for Electron require

[ronwang01]

Electron's module wrapper require an addtional global Buffer.

This was the PR where Electron added the additonal Buffer to the node module loader
electron/electron#8605

https://github.com/electron/node/blob/18aeda2077e7fe1ef9d7557692dda2e4d6a61860/lib/internal/modules/cjs/loader.js#L136

[tommoor]

Any chance of this getting merged? The module can't be used in Electron without it

[xxczaki]

ping @zertosh

[xxczaki]

To @tommoor and everyone waiting for this PR to get merged:

I created a copy of this package, which includes changes made in this Pull Request 😄

https://www.npmjs.com/package/@akepinski/v8-compile-cache

Note: This is just a temporary solution.

[zertosh]

Sorry, I take a look in the next day or two. I need to understand what the consequence of this is for non-Electron environments.

[xxczaki]

@zertosh Thanks!

[zertosh]

Electron 2.x's Node fork, includes Buffer in the module wrapper (link), and also calls the compiled wrapper with Buffer (link). Electron 4.x's Node fork does the same (wrapper, call). But, Electron 6.x's Node fork no longer includes Buffer in the wrapper args (link), or process or global for that matter. This is consistent with regular Node 12.x behavior (link). However, there seems to be an oversight in Electron, where the wrapper is still called with process, global and Buffer (link). This doesn't matter for this change, just documenting my observation. AFAICT, there's no harm in calling the wrapper with extra arguments. JavaScript just ignores them, plus, arguments isn't accessed anywhere.

[zertosh]

Published as v8-compile-cache@2.1.0