Expose require.resolve.paths()
#20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zertosh Is there any hope of getting this merged and released? It's a terrific module that benefits our application's performance significantly, but breaks the node SDK in this one small but important way. I have a potential workaround to monkey patches the gap, but it's much uglier than this actual fix. |
|
Let me take a look at re-syncing |
|
Thanks! |
zertosh
requested changes
May 10, 2019
| @@ -161,6 +162,7 @@ class NativeCompileCache { | |||
| require.resolve = function(request, options) { | |||
| return Module._resolveFilename(request, mod, false, options); | |||
| }; | |||
| require.resolve.paths = resolvePaths; | |||
There was a problem hiding this comment.
paths depends on the calling module: https://github.com/nodejs/node/blob/v12.2.0/lib/internal/modules/cjs/helpers.js#L26-L29
As-is, every module that uses require.paths would be doing so using the v8-compile-cache's require.paths - not the one unique to them.
|
Published the fix as |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #17 - overriding
require.resolveremovesrequire.resolve.pathsfrom existence. This PR ensures it is proxies as-is.Closes #17