Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #204

Merged
merged 264 commits into from
Jul 9, 2018
Merged

Conversation

BenjaminHae
Copy link
Collaborator

So this is a big one.
I've moved a lot of stuff in the frontend into ~3 classes:

  • multiple backend classes - does communication to the server keeps track of the clients state
  • EncryptionWrapper - does cryptography
  • Account - keeps track of an account

This makes it a lot easier to add new features and change parts. (My goal is to get rid of CryptoJS and move to the Web Crypto API which is a lot faster but makes heavy use of promises, so I've moved everything crypto related into promises).

Additionally a "copy to clipboard" plugin has been added.

As jQuery 2 is not getting patches anymore we need to update to jQuery 3. This implies an update of bootstrap to version 3.3.7.

Everything (but backup recovery) should be working right now. Not everything is completely refactored yet (for example usage of SessionStorage). But the most important parts are.

You can just use this version without any changes to the database. It should even possible to simply switch between the new and old version.

These changes however are not yet supported by the browser addon. My time is very limited right now, but I hope to get it done sometime soon.

@BenjaminHae
Copy link
Collaborator Author

Just a short update: I'm currently trying to get the browser plugins to work. Then I'll check the issues mentioned by @Pofilo(thank you very much!).

@zeruniverse
Copy link
Owner

What's the current progress?

@BenjaminHae
Copy link
Collaborator Author

File recovery is not done yet, so is the timeout. Everything else (including the chrome addon) works as expected.
I hope I find some time this weekend.

@zeruniverse
Copy link
Owner

zeruniverse commented Jun 20, 2018 via email

@BenjaminHae
Copy link
Collaborator Author

Ok, I think everything is done.
I'm going to replace my normal instance with this version this evening and see how it goes. If there are no issues then, I think we can release this version at the end of this week.

@BenjaminHae
Copy link
Collaborator Author

It worked flawlessly for me the last two weeks so I'm going to merge it tomorrow if nobody disagrees.

@zeruniverse
Copy link
Owner

zeruniverse commented Jul 8, 2018 via email

@BenjaminHae BenjaminHae merged commit 2b3e13c into zeruniverse:master Jul 9, 2018
@zeruniverse
Copy link
Owner

Is there any functionality change? i.e. do I need to change anything in my database?

@BenjaminHae
Copy link
Collaborator Author

No, you just have to clear your browser cache.

@zeruniverse
Copy link
Owner

zeruniverse commented Jul 10, 2018 via email

@zeruniverse
Copy link
Owner

Hi @BenjaminHae

Can u confirm that the changing password functionality is working correctly? i.e. if user has passwords and attached files, after changing login password, everything still remains unchanged at the user side.

Thanks for your hard work btw.

@BenjaminHae
Copy link
Collaborator Author

BenjaminHae commented Jul 25, 2018 via email

@BenjaminHae BenjaminHae deleted the refactoringDesiredState branch July 28, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants