-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #204
Refactoring #204
Conversation
Just a short update: I'm currently trying to get the browser plugins to work. Then I'll check the issues mentioned by @Pofilo(thank you very much!). |
cleared timeout interval after logout
What's the current progress? |
File recovery is not done yet, so is the timeout. Everything else (including the chrome addon) works as expected. |
Oh you don’t need to rush. I just want to keep updated.
Thank you for your work!
…On Tue, Jun 19, 2018 at 9:51 PM Benjamin Häublein ***@***.***> wrote:
File recovery is not done yet, so is the timeout. Everything else
(including the chrome addon) works as expected.
I hope I find some time this weekend.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEbvNMJZrA-qsk1zPYoQ9OCYpJchkx3Tks5t-dTXgaJpZM4TzGMD>
.
|
Ok, I think everything is done. |
It worked flawlessly for me the last two weeks so I'm going to merge it tomorrow if nobody disagrees. |
Agree
…On Sun, Jul 8, 2018 at 5:20 AM Benjamin Häublein ***@***.***> wrote:
It worked flawlessly for me the last two weeks so I'm going to merge it
tomorrow if nobody disagrees.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEbvNHs_yS7H9g9-8oA1SOyhwR-KLc0Eks5uEfkUgaJpZM4TzGMD>
.
|
Is there any functionality change? i.e. do I need to change anything in my database? |
No, you just have to clear your browser cache. |
Cool
…On Mon, Jul 9, 2018 at 9:54 PM Benjamin Häublein ***@***.***> wrote:
No, you just have to clear your browser cache.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEbvNPHOf-_prxhDd7Sb3IJh07cFQDMGks5uFDODgaJpZM4TzGMD>
.
|
Hi @BenjaminHae Can u confirm that the changing password functionality is working correctly? i.e. if user has passwords and attached files, after changing login password, everything still remains unchanged at the user side. Thanks for your hard work btw. |
Yes, that was one of the scenarios I explicitly checked.
…On Wed, 25 Jul 2018, 07:30 Jeffery Zhao, ***@***.***> wrote:
Hi @BenjaminHae <https://github.com/BenjaminHae>
Can u confirm that the changing password functionality is working
correctly? i.e. if user has passwords and attached files, after changing
login password, everything still remains unchanged at the user side.
Thanks for your hard work btw.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#204 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHCzsYAfSBCZ2m6y3knbukoycU51ej1rks5uKAKGgaJpZM4TzGMD>
.
|
So this is a big one.
I've moved a lot of stuff in the frontend into ~3 classes:
This makes it a lot easier to add new features and change parts. (My goal is to get rid of CryptoJS and move to the Web Crypto API which is a lot faster but makes heavy use of promises, so I've moved everything crypto related into promises).
Additionally a "copy to clipboard" plugin has been added.
As jQuery 2 is not getting patches anymore we need to update to jQuery 3. This implies an update of bootstrap to version 3.3.7.
Everything (but backup recovery) should be working right now. Not everything is completely refactored yet (for example usage of SessionStorage). But the most important parts are.
You can just use this version without any changes to the database. It should even possible to simply switch between the new and old version.
These changes however are not yet supported by the browser addon. My time is very limited right now, but I hope to get it done sometime soon.