Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check when getting effect type name #35

Closed
zeshan321 opened this issue Apr 14, 2021 · 4 comments
Closed

Add null check when getting effect type name #35

zeshan321 opened this issue Apr 14, 2021 · 4 comments

Comments

@zeshan321
Copy link
Owner

zeshan321 commented Apr 14, 2021

Add null check before getting effect type name and adding to list:

PotionData potionData = potionMeta.getBasePotionData();
possibleMaterials.add(potionData.getType().getEffectType().getName() + "_" + name);

@zeshan321
Copy link
Owner Author

[11:43:36] [Server thread/ERROR]: Could not pass event PlayerItemHeldEvent to ActionHealth v3.5.2
java.lang.NullPointerException: null
at com.zeshanaslam.actionhealth.action.ActionHelper.getName(ActionHelper.java:80) ~[?:?]
at com.zeshanaslam.actionhealth.action.ActionHelper.executeTriggers(ActionHelper.java:31) ~[?:?]
at com.zeshanaslam.actionhealth.action.ActionListener.onSwap(ActionListener.java:99) ~[?:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor136.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[minecraft_server.jar:git-Paper-592]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[minecraft_server.jar:git-Paper-592]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[minecraft_server.jar:git-Paper-592]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:1905) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.PacketPlayInHeldItemSlot.a(SourceFile:30) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.PacketPlayInHeldItemSlot.a(SourceFile:8) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:35) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.TickTask.run(SourceFile:18) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.MinecraftServer.bb(MinecraftServer.java:1252) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.MinecraftServer.executeNext(MinecraftServer.java:1245) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1319) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1116) ~[minecraft_server.jar:git-Paper-592]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:289) ~[minecraft_server.jar:git-Paper-592]
at java.lang.Thread.run(Thread.java:834) [?:?]

@zeshan321
Copy link
Owner Author

Issue occurs when Action system is enabled:

Action:
  Enabled: true
  # In seconds
  TagLength: 20
  # Amount of entities a player can tag during combat. -1 for unlimited
  TagAmount: 2
  Events:
    CONSUME:
      GOLDEN_APPLE: '&7&l{name} consumed &cgolden apple&7&l!'
      REGENERATION_POTION: '&7&l{name} consumed &cregen potion&7&l!'
    RIGHTCLICK:
      ENDER_PEARL: '&7&l{name} used &cender pearl&7&l!'
    SWAP:
      ENDER_PEARL: '&7&l{name} swapped to &cender pearls&7&l. {usestyle}&7&l'
      POTION: '&7&l{name} swapped to &cpotion&7&l. {usestyle}&7&l'
    DAMAGE:
      ANY: '&7&l{name}: {usestyle}'
      # Supports DamageCause if 'ANY' not being used
      #LAVA: '&4On fire!'
      #ENTITY_SWEEP_ATTACK: '&7You swept them!

@zeshan321 zeshan321 added the bug label Apr 14, 2021
@CookieGuy123
Copy link

:)
-maehb

@zeshan321
Copy link
Owner Author

Fixed in latest. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants