Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library doesn't work well with mini-css-extract-plugin #30

Closed
julienw opened this issue Nov 26, 2018 · 4 comments
Closed

The library doesn't work well with mini-css-extract-plugin #30

julienw opened this issue Nov 26, 2018 · 4 comments

Comments

@julienw
Copy link

julienw commented Nov 26, 2018

Since Webpack 4 the webpack folks recommend using mini-css-extract-plugin to extract the CSS data into its own file. But this doesn't work well with this library. I think that's because the distributed version is a compiled version. I don't know if there's an easy fix for this but you may have an idea...

@julienw julienw changed the title The library doesn't work zell with mini-css-extract-plugin The library doesn't work well with mini-css-extract-plugin Nov 26, 2018
@julienw
Copy link
Author

julienw commented Dec 13, 2018

react-tabs exposes both a JS file and a CSS file, and a user needs to import the CSS file explicitely. I believe this would fix this issue. This would be nice but would be a breaking change.

The nice side effect is that this would allow a user to not use the default CSS -- in our project we had to override a lot of the default style.

@zesik
Copy link
Owner

zesik commented Feb 9, 2019

Hi, sorry for replying late! Was having some busy months.

I'm planning to stop compiling CSS and release separated CSS file in next major release. Hopefully it can help with the problem you're facing.

@zesik
Copy link
Owner

zesik commented Mar 10, 2019

This should be fixed in version 4. Please give it a try.

@julienw
Copy link
Author

julienw commented Mar 14, 2019

Thanks, we'll try and give some feedback :) In the mean time you can close this bug if you think this is fixed!

@zesik zesik closed this as completed May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants