[Hotfix v1.4] Manque un formulaire lors d'un echec import archive #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'tutorial': self.bigtuto.pk, | ||
| 'import-archive': "importer"}, | ||
| ) | ||
| self.assertEqual(result.status_code, 200) |
There was a problem hiding this comment.
Il faudrait verifier que tu es rediriger sur la bonne page, sinon ca peut ptet tout autant dire "succes, on est rendu sur la bonne page" plutot que "erreur, ce fichier est mauvais"
|
Point de vu code ca me semble bon (pas teste en vrai) mais point de vue test une toute petite amelioration pourrait etre faite :) |
|
Effectivement j'avais oublié un |
|
Rapport de QA : ça marche dans les deux sens (plus de 500 mais import toujours possible avec la bonne archive). À merger, donc :) |
SpaceFox
added a commit
that referenced
this pull request
Dec 19, 2014
[Hotfix v1.4] Manque un formulaire lors d'un echec import archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA : Par le formulaire "Envoi d'une archive", envoyer un fichier quelconque et vérifier qu'on ne se mange pas une erreur 500.