Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination page d'aides aux tutos #1986

Closed
wants to merge 3 commits into from

Conversation

poulp
Copy link
Contributor

@poulp poulp commented Dec 24, 2014

Q R
Correction de bugs ? oui
Nouvelle Fonctionnalité ? non
Tickets concernés #1974

Renvoi une erreur 404 si la pagination de l'aide aux tutos n'existe pas.

Pour la QA sur la page d'aide aux tutos :

@gustavi
Copy link
Contributor

gustavi commented Dec 24, 2014

Je ne suis pas d'accord avec ton 3è exemple. Pour moi c'est 404.

@poulp
Copy link
Contributor Author

poulp commented Dec 24, 2014

Le problème c'est que le 3eme exemple leve PageNotAnInteger, si je met un raise 404 dessus, ça rend innaccesible la page sans pagination. Du coup je vais reprendre le code des forums

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling d65acfe on poulp:fix_pagination into 93c60c4 on zestedesavoir:dev.

@poulp poulp closed this Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants