Bump des dépendances npm + clean du Gulpfile + fix les warnings JSHint #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- passe tous les chemins "composés" par path.join - vire browserify qui ne sert pas encore (et qui servira peut-être jamais) - corrige quelques erreurs de config (options inutiles, mauvais chemins pour le scss des erreurs)
|
J'ai réussi à compiler le front (sous unix), je ne me prononce pas sur le code, je ne connaît pas les outils. |
|
Pour que tout le monde ait les mêmes versions des dépendances, peux-tu les mettre toutes en strictes ? :) |
Done ! |
|
Ça marche toujours donc je merge :) |
pierre-24
added a commit
that referenced
this pull request
Apr 23, 2015
Bump des dépendances npm + clean du Gulpfile + fix les warnings JSHint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Y'a pas mal de petites choses dans cette PR qui touchent toutes au système de build du front.
css-spritepour éviter qu'il casse tout (ce paquet utilise des binaries, et a tendance à pas être super stable...)QA
Mettre à jour les dépendances, et virer les dépendances inutilisées (
npm install && npm prune)Clean + build le front (
npm run clean && npm run build)Vérifier que le front est bien généré (donc tester globalement le site)