Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction des erreurs/alertes de flake8 #3462

Merged
merged 1 commit into from
Mar 29, 2016

Conversation

orandin
Copy link
Contributor

@orandin orandin commented Mar 26, 2016

Q R
Type de modification Refactoring
Ticket(s) (issue(s)) concerné(s)

Mon linter Flake8 sur Atom a vu rouge sur le fichier settings.py.
Voici toutes les erreurs répertoriées :

- Flake8 Warning F401 — 'dirname' imported but unusedat line 5 col 21
- Flake8 Error E261 — at least two spaces before inline commentat line 97 col 70
- Flake8 Error E123 — closing bracket does not match indentation of opening bracket's lineat line 150 col 13
- Flake8 Error E265 — block comment should start with '# 'at line 223 col 9
- Flake8 Error E265 — block comment should start with '# 'at line 230 col 9
- Flake8 Error E402 — module level import not at top of fileat line 369 col 1
- Flake8 Warning F811 — redefinition of unused 'message_constants' from line 8at line 369 col 1
- Flake8 Error E261 — at least two spaces before inline commentat line 552 col 62
- Flake8 Warning F403 — 'from settings_prod import *' used; unable to detect undefined namesat line 575 col 5

@@ -2,7 +2,6 @@

import os
import sys
from os.path import dirname
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake8 Warning F401 — 'dirname' imported but unusedat line 5 col 21

@coveralls
Copy link

Coverage Status

Coverage decreased (-34.5%) to 53.435% when pulling 8a55378 on orandin:patch-flake8 into 9c8e3f7 on zestedesavoir:dev.

@gustavi
Copy link
Contributor

gustavi commented Mar 27, 2016

À changer : cette ligne et celle-ci.

@coveralls
Copy link

Coverage Status

Coverage increased (+34.4%) to 87.888% when pulling 2e87dcb on orandin:patch-flake8 into 6485083 on zestedesavoir:dev.

@gustavi
Copy link
Contributor

gustavi commented Mar 29, 2016

Parfait, merci

@gustavi gustavi merged commit f175ae3 into zestedesavoir:dev Mar 29, 2016
@gustavi gustavi added Evolution C-Back Concerne le back-end Django labels Mar 29, 2016
@gustavi gustavi added this to the Version de développement milestone Mar 29, 2016
@orandin orandin mentioned this pull request Mar 29, 2016
@orandin orandin deleted the patch-flake8 branch March 29, 2016 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Back Concerne le back-end Django
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants