Les tags dans les menus déroulant des contenus sont filtrés par type. #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artragis
reviewed
Jan 20, 2017
| content.public_version = published | ||
| content.save() | ||
|
|
||
| content = PublishableContentFactory(type="ARTICLE") |
There was a problem hiding this comment.
pour réduire le nombre de lignes tu peux faire :
content = PublishedContentFactory(type="ARTICLE", author_list=[ProfileFactory().user])
content.add_tags(tags_article)
content.save()
DevHugo
reviewed
Feb 1, 2017
| @@ -27,6 +38,9 @@ def setUp(self): | |||
| self.forum12.group.add(Group.objects.filter(name='staff').first()) | |||
| self.forum12.save() | |||
|
|
|||
| # don't build PDF to speed up the tests | |||
| settings.ZDS_APP['content']['build_pdf_when_published'] = False | |||
| shutil.rmtree(settings.MEDIA_ROOT) | ||
|
|
||
| # re-active PDF build | ||
| settings.ZDS_APP['content']['build_pdf_when_published'] = True |
There was a problem hiding this comment.
Pareil ici, j'ai peur que si on lance les tests sur plusieurs thread ou avec plusieurs processus ça passe pas.
There was a problem hiding this comment.
en effet vaut mieux utiliser override_settings.
There was a problem hiding this comment.
Mmmh, en effet. Sauf que je le reconnais bien, ce bout de code, il est de moi, et personne m'avais jamais rien dit :p (y'a son copain qui traine dans un autre fichier de test, note)
|
Rapport de QA: ok, ça marche très bien :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA
Concrètement sur la prod ça évite que l'on ait le tag Interview dans le menu tuto : ce lien mène à une 404. Du coup on aura une meilleure expérience utilisateur (navigation à facette, etc.)