Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprime des morceaux de code morts #4245

Merged
merged 3 commits into from
Mar 24, 2017
Merged

Supprime des morceaux de code morts #4245

merged 3 commits into from
Mar 24, 2017

Conversation

gllmc
Copy link
Member

@gllmc gllmc commented Mar 14, 2017

Q R
Type de modification refactorisation
Ticket(s) (issue(s)) concerné(s) aucun

Cette pull request supprime des morceaux de code morts (utilisés nulle part).

QA

Code review seulement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-34.0%) to 54.672% when pulling db7d2a9 on GCodeur:supprime_code_mort into 2edbdb5 on zestedesavoir:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-34.0%) to 54.672% when pulling db7d2a9 on GCodeur:supprime_code_mort into 2edbdb5 on zestedesavoir:dev.

@gllmc
Copy link
Member Author

gllmc commented Mar 14, 2017

Jolie erreur : un test vérifiait qu'une valeur n'était pas dans le code, mais cette fois-ci, elle était dans le token CSRF. :x

J'édite le test en conséquence du coup.

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.04%) to 88.69% when pulling cde62c2 on GCodeur:supprime_code_mort into 2edbdb5 on zestedesavoir:dev.

@coveralls
Copy link

coveralls commented Mar 14, 2017

Coverage Status

Coverage increased (+0.04%) to 88.69% when pulling 596dff0 on GCodeur:supprime_code_mort into 2edbdb5 on zestedesavoir:dev.

@gllmc gllmc added C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité labels Mar 21, 2017
@vhf
Copy link
Contributor

vhf commented Mar 24, 2017

Cool, merci !

@vhf vhf merged commit f6f1c12 into zestedesavoir:dev Mar 24, 2017
@vhf vhf added this to the Version de développement milestone Mar 24, 2017
@gllmc gllmc deleted the supprime_code_mort branch July 17, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Back Concerne le back-end Django S-Refactorisation Améliore le code existant sans forcément ajouter de nouvelle fonctionnalité
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants