Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permet de désactiver l'aide Markdown #4335

Merged
merged 2 commits into from
May 9, 2017
Merged

Permet de désactiver l'aide Markdown #4335

merged 2 commits into from
May 9, 2017

Conversation

gllmc
Copy link
Member

@gllmc gllmc commented May 7, 2017

Q R
Type de modification évolution
Ticket(s) (issue(s)) concerné(s) #4334

QA

  • Reconstruire le front et effectuer les migrations, vider le cache.
  • Se connecter sous n'importe quelle compte et vérifier que l'aide Markdown s'affiche.
  • Désactiver l'option dans les paramètres du profil et vérifier qu'elle ne s'affiche plus.
  • Code review.

@gllmc gllmc added C-Front Concerne l'interface du site QA svp labels May 7, 2017
Situphen
Situphen reviewed May 7, 2017
View reviewed changes
zds/member/views.py
'email_for_answer': profile.email_for_answer,
'sign': profile.sign,
'is_dev': profile.is_dev(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette suppression est voulue ou c'est une erreur ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, elle est voulue. J'avoue que j'ai un peu fait ça "au passage" vu que j'étais sur ce formulaire. Cette ligne servait à afficher ou non le champ du token GitHub et n'est plus utilisée maintenant que le formulaire est séparé. Un oubli de #4246.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'accord !

@coveralls
Copy link

coveralls commented May 7, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 88.626% when pulling cff0149 on GCodeur:fix-4334 into a06b161 on zestedesavoir:dev.

@artragis artragis self-assigned this May 9, 2017
@artragis
Copy link
Member

artragis commented May 9, 2017

J'ia eu des soucis avec la debug toolbar mais sinon ,QA OK.

@artragis artragis merged commit 96d91fd into zestedesavoir:dev May 9, 2017
@gllmc gllmc added this to the Version de développement milestone May 9, 2017
@gllmc gllmc removed the QA svp label May 9, 2017
@gllmc gllmc deleted the fix-4334 branch July 17, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Situphen Situphen Situphen left review comments

Assignees

@artragis artragis

Labels
C-Front Concerne l'interface du site
Projects
None yet
Milestone
v24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gllmc @coveralls @artragis @Situphen