Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute une note sur la ligne éditoriale lors de l'ajout d'un contenu #4351

Merged
merged 2 commits into from
May 25, 2017
Merged

Conversation

gllmc
Copy link
Member

@gllmc gllmc commented May 24, 2017

Q R
Type de modification évolution
Ticket(s) (issue(s)) concerné(s) #4348

QA

  • Ouvrir la page de création d'un contenu.
  • Vérifier qu'une note sur la ligne éditoriale a été ajoutée et que le lien est correct.
  • Code review.

@gllmc gllmc added C-Front Concerne l'interface du site QA svp labels May 24, 2017
@@ -22,5 +22,11 @@


{% block content %}
<div class="content-wrapper">
<div class="alert-box info">
Vous allez créer un nouveau contenu sur {{ site_name }}. Pensez à prendre connaissance de la <a href="{{ editorial_line_link }}">ligne éditoriale du site</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En effet, j'ai vraiment un problème avec ça. :-°

@@ -506,7 +506,9 @@
'import_image_prefix': 'archive',
'build_pdf_when_published': True,
'maximum_slug_size': 150,
'sec_per_minute': 1500
'sec_per_minute': 1500,
'editorial_line_link':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu peux tout mettre sur une seule ligne

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça faisait plus de 120 caractères. :/

@@ -51,6 +51,7 @@
from zds.utils.models import HelpWriting
from zds.utils.mps import send_mp
from zds.utils.paginator import ZdSPagingListView, make_pagination
from zds import settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en général on place cette ligne avant tout les from zds.foo ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok !

@coveralls
Copy link

coveralls commented May 25, 2017

Coverage Status

Coverage increased (+0.004%) to 88.955% when pulling d5d1f25 on GCodeur:fix-4348 into 85fb311 on zestedesavoir:dev.

Copy link
Contributor

@gustavi gustavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA : OK

@gustavi gustavi merged commit 7e1bf18 into zestedesavoir:dev May 25, 2017
@gustavi gustavi added this to the Version de développement milestone May 25, 2017
@gllmc gllmc removed the QA svp label May 30, 2017
@gllmc gllmc deleted the fix-4348 branch July 17, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Front Concerne l'interface du site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants