Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout d'un champ 'licence préférée' dans le profil #4380

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Ajout d'un champ 'licence préférée' dans le profil #4380

merged 3 commits into from
Jun 26, 2017

Conversation

poulp
Copy link
Contributor

@poulp poulp commented Jun 18, 2017

Q R
Type de modification évolution
Ticket(s) (issue(s)) concerné(s) #4295

QA

  • Aller dans les paramètres du profil utilisateur et mettre à jour le champs 'Licence préférée'
  • Créer un contenu (n'importe lequel) et vérifier que la valeur par défaut du champ licence correspond à celle définie dans le profil

@coveralls
Copy link

coveralls commented Jun 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 89.065% when pulling 45ff367 on poulp:feature_4295 into 30be5f3 on zestedesavoir:dev.

@gllmc gllmc self-requested a review June 18, 2017 20:35
@gllmc gllmc added C-Back Concerne le back-end Django QA svp labels Jun 18, 2017
gllmc
gllmc reviewed Jun 20, 2017
View reviewed changes
Copy link
Member

@gllmc gllmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas sûr que la méthode utilisée soit la bonne. Plutôt qu'un TextField, utiliser une clé étrangère vers la table des licences me paraît plus judicieux. ;)

zds/member/models.py Outdated
@@ -57,6 +57,7 @@ class Meta:
biography = models.TextField('Biographie', blank=True)
karma = models.IntegerField('Karma', default=0)
sign = models.TextField('Signature', max_length=500, blank=True)
licence = models.TextField('Licence préférée', null=True, blank=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut éviter de mettre null=True aux TextField.

zds/tutorialv2/views/views_contents.py Outdated
assuming he just wants the default "All rights reserved" option.
Handle content creation. Since v22, we explicitely ask for user to choose a licence instead of
assuming he just wants the default "All rights reserved" option. Even though, the user can configure
a default licence in his profile.
Copy link
Member

@gllmc gllmc Jun 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a plusieurs fautes dans cette phrase. Il faut utiliser they au lieu de he comme pronom pour a user. Ici, un pluriel est plus adéquat.
Suggestion de @vhf : "Handle content creation. Since v22 a licence must be explicitly selected instead of defaulting to "All rights reserved". Users can however set a default licence in their profile."

@poulp
Copy link
Contributor Author

poulp commented Jun 21, 2017

Changements faits ;)

@coveralls
Copy link

coveralls commented Jun 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 89.065% when pulling 1915040 on poulp:feature_4295 into 30be5f3 on zestedesavoir:dev.

@artragis artragis added this to the Version de développement milestone Jun 26, 2017
@AmarOk1412
Copy link
Member

@poulp QA: Ok ! Merci de ta contribution.

@artragis
Copy link
Member

(j'étais en train de faire la QA aussi tiens, les grands esprits se rencontrent :p)

@artragis artragis merged commit 491018d into zestedesavoir:dev Jun 26, 2017
@gllmc gllmc removed the QA svp label Jun 26, 2017
@poulp poulp deleted the feature_4295 branch June 26, 2017 17:16
@A-312 A-312 mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gllmc gllmc gllmc left review comments

Assignees
No one assigned
Labels
C-Back Concerne le back-end Django
Projects
None yet
Milestone
v24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@poulp @coveralls @AmarOk1412 @artragis @gllmc