npm run gulp
survit en cas d’erreur
#4424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avant,
npm run gulp
crashait bêtement lorsqu’on oubliait un;
dans le CSS. Pas terrible.Avec ce patch, il continue d’observer les fichiers. Notez que
npm run build
quitte toujours comme il faut (avec un statut non nul) en cas d’erreur (sinon ça serait pas cool pour la CI).C’est un peu cochon mais Gulp est assez pété “by design”. Si quelqu’un a une meilleure solution, je suis preneur.
C’est basé là-dessus : gulpjs/gulp#259 (comment)
QA
Testez
npm run gulp
etnpm run build
, avec et sans erreurs dans lesassets/
.