Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remplace import zds.settings par from django.conf import settings #4455

Merged
merged 2 commits into from
Aug 6, 2017

Conversation

motet-a
Copy link
Contributor

@motet-a motet-a commented Aug 5, 2017

Avant ce commit, lorsque l’on faisait :

$ manage.py runserver 0.0.0.0:8000 --settings zds.my_custom_settings

zds.settings restait zds.settings alors que django.conf.settings
vallait zds.my_custom_settings.

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) #4435

QA

Essayez d’importer zds.settings quelque part et lancez ./scripts/no_import_zds_settings.sh : Si tout se passe bien, vous vous ferez insulter copieusement.

Avant ce commit, lorsque l’on faisait :

    $ manage.py runserver 0.0.0.0:8000 --settings zds.my_custom_settings

`zds.settings` restait `zds.settings` alors que `django.conf.settings`
vallait `zds.my_custom_settings`.

Fix zestedesavoir#4435.
@coveralls
Copy link

coveralls commented Aug 5, 2017

Coverage Status

Coverage decreased (-0.009%) to 89.264% when pulling c9f4fa1 on motet-a:ne-pas-import-zds-settings into 233d031 on zestedesavoir:dev.

@vhf vhf merged commit ff7dd1f into zestedesavoir:dev Aug 6, 2017
@vhf vhf modified the milestone: Version de développement Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants