-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ajoute le _blank pour le lien vers les forums #4522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rapport de QA: quasiment
@@ -33,7 +33,7 @@ | |||
$title = $("<a></a>").attr("target", "_blank"); | |||
$title.text(topic.title).attr("href", topic.url).attr("title", topic.subtitle); | |||
var $topicDate = new Date(topic.pubdate).toLocaleDateString(); | |||
var $forumLink = $("<a></a>").text(topic.forumTitle).attr("href", topic.forumUrl); | |||
var $forumLink = $("<a></a>").text(topic.forumTitle).attr("href", topic.forumUrl).attr("target", "_blank"); | |||
$("<li></li>").text(" dans le forum ").append($forumLink).append(" le " + $topicDate).prepend($title).appendTo($ul); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Du coup, faudrait faire de même sur le lien du forum, question de logique :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il y es déjà non?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Donc, en ayant rebuildé le front, ça va mieux :)
QA
{ici le lien}
" et assurez-vous que cela s'ouvre dans un autre onglet