Corrige les erreurs 500 liées à l'attribution des casquettes #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artragis
requested changes
Aug 22, 2017
zds/member/views.py
Outdated
| @@ -800,7 +800,7 @@ def add_hat(request, user_pk): | |||
|
|
|||
| user = get_object_or_404(User, pk=user_pk) | |||
|
|
|||
| hat_name = request.POST.get('hat', None) | |||
| hat_name = request.POST.get('hat', None).strip() | |||
There was a problem hiding this comment.
du coup vaut mieux remplacer le None par '' sinon tu vas avoir un AttributeError.
| @@ -19,7 +19,7 @@ def handle(self, *args, **options): | |||
| except Group.DoesNotExist: | |||
| raise CommandError('Group {} does not exist.'.format(options['group'])) | |||
|
|
|||
| hat_name = options['hat'] | |||
| hat_name = options['hat'].strip() | |||
There was a problem hiding this comment.
options.get('hat', '').strip()
There was a problem hiding this comment.
C'est moins important ici, mais ça vaut le coup quand même, je m'en occupe.
| @@ -480,7 +480,7 @@ class Hat(models.Model): | |||
| that a moderation message was posted by a staff member. | |||
| """ | |||
|
|
|||
| name = models.CharField('Casquette', max_length=40, unique=True) | |||
| name = models.CharField('Casquette', max_length=40) | |||
There was a problem hiding this comment.
du coup je suis pas sûr que supprimer le unique soit une bonne idée.
There was a problem hiding this comment.
C'est nécessaire pour résoudre le problème des smileys (deux casquettes identiques avec un caractère UTF-8 différent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'erreur est causée par le fait que
unique=Truesupporte mal l'UTF-8. Je l'enlève car leget_or_createfait déjà cette vérification. Par ailleurs, j'empêche les espaces au début et à la fin qui n'ont aucune raison d'être. ^^QA
☆et♦) à un membre et vérifier qu'elles sont correctement attribuées.