New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor les transactions pour pas raiser dedans #4605

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
4 participants
@vhf
Member

vhf commented Sep 1, 2017

Q R
Type de modification refacto
Ticket(s) (issue(s)) concerné(s) -

Backporté depuis #4389

QA

  • Instruction 1 (exemple : lancez python manage.py migrate et yarn test)
  • Instruction 2
  • ...
  • Code review
is_visible = self.object.is_visible
if can_read and ((is_author and is_visible) or request.user.has_perm('forum.change_post')):
return super(PostEdit, self).dispatch(request, *args, **kwargs)
raise PermissionDenied

This comment has been minimized.

@artragis

artragis Sep 1, 2017

Contributor

ça vaudrait presque le coup d'avoir notre propre context_manager qui raise PermissionDenied si on n'a pas fait de return à la fin du with.

@artragis

artragis Sep 1, 2017

Contributor

ça vaudrait presque le coup d'avoir notre propre context_manager qui raise PermissionDenied si on n'a pas fait de return à la fin du with.

This comment has been minimized.

@vhf

vhf Sep 1, 2017

Member

C'est une idée. Bon là c'est explicite et simple, c'est pas plus mal.

@vhf

vhf Sep 1, 2017

Member

C'est une idée. Bon là c'est explicite et simple, c'est pas plus mal.

Show outdated Hide outdated zds/notification/models.py Outdated

@zestedesavoir zestedesavoir deleted a comment from coveralls Sep 1, 2017

@zestedesavoir zestedesavoir deleted a comment from coveralls Sep 1, 2017

@zestedesavoir zestedesavoir deleted a comment from coveralls Sep 1, 2017

@zestedesavoir zestedesavoir deleted a comment from coveralls Sep 1, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 1, 2017

Coverage Status

Coverage increased (+0.02%) to 89.678% when pulling 70dbcd1 on vhf:refactor-transactions into c6e959e on zestedesavoir:dev.

coveralls commented Sep 1, 2017

Coverage Status

Coverage increased (+0.02%) to 89.678% when pulling 70dbcd1 on vhf:refactor-transactions into c6e959e on zestedesavoir:dev.

@zestedesavoir zestedesavoir deleted a comment from coveralls Sep 1, 2017

@motet-a

This comment has been minimized.

Show comment
Hide comment
Member

motet-a commented Sep 18, 2017

@artragis

This comment has been minimized.

Show comment
Hide comment
@artragis

artragis Sep 19, 2017

Contributor

Apparament pas de conflit insoluble. Néanmoins un rebase est nécessaire pour faire passer travis sur la nouvelle base de code.

Contributor

artragis commented Sep 19, 2017

Apparament pas de conflit insoluble. Néanmoins un rebase est nécessaire pour faire passer travis sur la nouvelle base de code.

@motet-a motet-a added the C-Back label Sep 19, 2017

@artragis

This comment has been minimized.

Show comment
Hide comment
@artragis

artragis Dec 19, 2017

Contributor

tu peux faire un petit rebase stp?

Contributor

artragis commented Dec 19, 2017

tu peux faire un petit rebase stp?

@artragis

This comment has been minimized.

Show comment
Hide comment
@artragis

artragis Jan 26, 2018

Contributor

tu pourras rebase ça @vhf ?

Contributor

artragis commented Jan 26, 2018

tu pourras rebase ça @vhf ?

@vhf

This comment has been minimized.

Show comment
Hide comment
@vhf

vhf Jan 26, 2018

Member

@artragis C'est fait.

Member

vhf commented Jan 26, 2018

@artragis C'est fait.

@artragis artragis merged commit 26eff53 into zestedesavoir:dev Jan 26, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment