Refactor les transactions pour pas raiser dedans #4605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artragis
reviewed
Sep 1, 2017
| is_visible = self.object.is_visible | ||
| if can_read and ((is_author and is_visible) or request.user.has_perm('forum.change_post')): | ||
| return super(PostEdit, self).dispatch(request, *args, **kwargs) | ||
| raise PermissionDenied |
There was a problem hiding this comment.
ça vaudrait presque le coup d'avoir notre propre context_manager qui raise PermissionDenied si on n'a pas fait de return à la fin du with.
There was a problem hiding this comment.
C'est une idée. Bon là c'est explicite et simple, c'est pas plus mal.
zds/notification/models.py
Outdated
| @@ -117,6 +115,7 @@ def send_email(self, notification): | |||
| try: | |||
| msg.send() | |||
| except SMTPException: | |||
| LOG.error('Failed sending mail for %s', self, exc_info=True) | |||
| pass | |||
vhf
force-pushed
the
refactor-transactions
branch
2 times, most recently
from
58c7824
to
fe1f7f4
Compare
vhf
force-pushed
the
refactor-transactions
branch
from
fe1f7f4
to
6517807
Compare
|
Apparament pas de conflit insoluble. Néanmoins un rebase est nécessaire pour faire passer travis sur la nouvelle base de code. |
|
tu peux faire un petit rebase stp? |
|
tu pourras rebase ça @vhf ? |
vhf
force-pushed
the
refactor-transactions
branch
from
6517807
to
70dbcd1
Compare
|
@artragis C'est fait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporté depuis #4389
QA
python manage.py migrateetyarn test)