Améliore les commentaires de zds.tutorialv2.models.models_versioned #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motet-a
force-pushed
the
tutorials-models-comments
branch
from
03ee507
to
a67f75c
Compare
artragis
reviewed
Sep 25, 2017
| if len(base) > max_slug_size - 1 - max_suffix_digit_count: | ||
| # There is a `- 1` because of the dash between the slug | ||
| # itself and the numeric suffix. | ||
| base = base[:max_slug_size] - 1 - max_suffix_digit_count |
|
|
||
| def add_slug_to_pool(self, slug): | ||
| """Add a slug to the slug pool to be taken into account when generate a unique slug | ||
| def __add_slug_to_pool(self, slug): |
| @@ -715,13 +724,6 @@ def traverse(self, only_container=True): | |||
| elif not only_container: | |||
| yield child | |||
|
|
|||
| def is_part(self): | |||
zds/tutorialv2/tests/tests_models.py
Outdated
| @@ -72,6 +72,14 @@ def test_workflow_content(self): | |||
| self.assertTrue(self.part1.slug in versioned.children_dict.keys()) | |||
| self.assertTrue(self.chapter1.slug in versioned.children_dict[self.part1.slug].children_dict) | |||
|
|
|||
| def test_slug_pool(self): | |||
motet-a
force-pushed
the
tutorials-models-comments
branch
5 times, most recently
from
c9094d9
to
53589f5
Compare
motet-a
force-pushed
the
tutorials-models-comments
branch
from
53589f5
to
b423aa5
Compare
motet-a
force-pushed
the
tutorials-models-comments
branch
from
b423aa5
to
b7eb32a
Compare
motet-a
force-pushed
the
tutorials-models-comments
branch
from
b7eb32a
to
44bfd90
Compare
motet-a
force-pushed
the
tutorials-models-comments
branch
from
44bfd90
to
7dd7d7c
Compare
Ça me semble mieux mais ça peut contenir des fautes. Relisez attentivement, je n’ai pas un anglais parfait. Améliore légèrement quelque parties du code, au niveau de la génération des slugs notamment.
motet-a
force-pushed
the
tutorials-models-comments
branch
from
7dd7d7c
to
fbe4415
Compare
gllmc
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ça me semble mieux mais ça peut contenir des fautes. Relisez
attentivement, je n’ai pas un anglais parfait.
Améliore légèrement quelque parties du code, au niveau de la
génération des slugs notamment.
Numéro du ticket concerné (optionnel) : aucun
Contrôle qualité
Relisez.