Fix #5476 : Correction comportement bannière cookie #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
La bannière de cookies disparait maintenant après interaction de l'utilisateur sur celle-ci
|
On ne devrait pas attendre le fin mot de l'histoire ? |
|
Quel fin mot? L'histoire est déjà écrite : on doit obtenir le consentement car notre tracker c'est google analytic, comme on doit obtenir le consentement il faut qu'il soit explicite. Voilà. Maintenant y'a plus qu'à tester que la banière s'affiche bien, c'est tout. |
Rapport de QAQA OK La PR fait bien son boulot, à savoir, tant qu'on n'explicite pas son consentement (accepter, ou refuser), la boite reste présente. Un rebase et on pourra merger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La bannière de cookies disparait maintenant seulement après interaction de l'utilisateur sur celle-ci.
Numéro du ticket concerné (optionnel) : 5476