Ajoute le lancement du publication_watchdog au Makefile #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situphen
reviewed
Nov 2, 2019
|
(N'oubliez pas que dans un script en utilisant |
philippemilink
force-pushed
the
watchdog-makefile
branch
from
687eb00
to
e3ad246
Compare
Rapport de QA.Presque. La commande faite bien son boulot, mais si zmd est down, elle devrait planter. Un petit zmd-check ne serait pas de trop. |
|
Comme je disais plus haut, les erreurs avec makefile ne sont pas bloquantes, il faut les catch (a l'extérieur) ou ajouter une gestion d'erreur à l'intérieur (vu que tu as fais deux PR équivalentes, je pense que tu peux zmd-check sans trop de difficulté). |
philippemilink
force-pushed
the
watchdog-makefile
branch
from
e3ad246
to
d44904e
Compare
|
C'est corrigé, ça vérifie si ZMD est actif. |
|
QA, OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je pense que le titre est assez équivoque et que vous saurez quoi faire pour la QA ! 😄