Optimisation des requêtes SQL sur la page d'accueil #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situphen
changed the title
Situphen
force-pushed
the
opti-home
branch
2 times, most recently
from
32cf716
to
a80ceb4
Compare
artragis
requested changes
Apr 19, 2021
| @@ -215,8 +215,6 @@ def get_last_tutorials(self, number=0): | |||
| self.filter(type="TUTORIAL") | |||
| .filter(public_version__isnull=False) | |||
| .prefetch_related("authors") | |||
| .prefetch_related("authors__profile") | |||
There was a problem hiding this comment.
ça ne va pas être gênant de ne pas la charger?
There was a problem hiding this comment.
Non car cette fonction n'est utilisée que pour la page d'accueil et dans celle-ci pour les contenus on ne fait pas appel au profil des auteurs.
philippemilink
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Rapport de QA
Voici les mesures que moi j'obtiens:
connecté:
default 86.45 ms (140 requêtes including 100 similar and 24 duplicates )
default 55.70 ms (107 requêtes including 80 similar and 24 duplicates )
==> default 56.56 ms (99 requêtes including 63 similar and 8 duplicates )
default 56.56 ms (99 requêtes including 63 similar and 8 duplicates )
anonyme:
default 27.77 ms (111 requêtes including 84 similar and 22 duplicates )
default 22.03 ms (82 requêtes including 64 similar and 22 duplicates )
==> default 45.13 ms (82 requêtes including 56 similar and 8 duplicates )
default 34.57 ms (53 requêtes including 36 similar and 8 duplicates )
Ça diminue bien et tout fonctionne, donc c'est OK ✔️
@artragis je te laisse approuver et merger
artragis
approved these changes
Apr 20, 2021
Suivi des PR
automation
moved this from Modification demandée
to Fusionnable après rebase
Apr 20, 2021
artragis
added
C-Back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimisation des requêtes SQL sur la page d'accueil
Avant
Après
La différence entre la première requête et les autres est due au cache.