Utilise la méthode BulkRequest pour l'affichage des statistiques #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artragis
requested changes
Jun 12, 2021
| all_type_referrers = self.get_all_refs(urls, start_date, end_date, "Referrers.getReferrerType") | ||
| all_keywords = self.get_all_refs(urls, start_date, end_date, "Referrers.getKeywords") | ||
|
|
||
| for index, url in enumerate(urls): |
There was a problem hiding this comment.
je l'aurais nommé url_hierarchy_index pour rappeler que le principal besoin c'est les tutos big et moyens
There was a problem hiding this comment.
Qu'est-ce que tu aurais nommé url_hierarchy_index ?
There was a problem hiding this comment.
Hum, pour être honnête je pense que ça rendrait le code plus confus qu'autre chose. On a urls qui est une liste de NamedUrl sur laquelle on itère, à chaque itération on note l'index et l'élément en question. Il ne s'agit pas de l'index dans la hiérarchie du contenu (ce qui est comme ça que je comprends url_hierarchy_index).
artragis
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilise la méthode BulkRequest pour l'affichage des statistiques