Utilise le KaTeX de zmd pour ZdS #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemilink
added
the
hacktoberfest-accepted
philippemilink
force-pushed
the
katex-zmd
branch
from
bae0a07
to
e21b912
Compare
|
J'ai fusionné #6179 qui a touché au script d'installation donc tu as un petit conflit à résoudre. Une fois que ce sera fait je m'occuperai de la QA. |
philippemilink
force-pushed
the
katex-zmd
branch
from
e21b912
to
d181638
Compare
|
Corrigé. |
philippemilink
moved this from Modification demandée
to En attente de QA
in Suivi des PR
Situphen
requested changes
Oct 7, 2021
Pour être sûr d'avoir vraiment les mêmes versions dans les deux modules. Fix zestedesavoir#6140
philippemilink
force-pushed
the
katex-zmd
branch
from
d181638
to
7d15dfc
Compare
|
Bien vu, corrigé ! |
philippemilink
moved this from Modification demandée
to En attente de QA
in Suivi des PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pour être sûr d'avoir vraiment les mêmes versions dans les deux modules.
Fix #6140
Contrôle qualité
make updateIl faut peut-être aussi vérifier que les maths sont bien rendues dans les epubs.
@Situphen J'ai vérifié dans les scripts ansible, on installe bien zmd avant de builder le front.
Par contre, en faisant la PR, j'ai été surpris que
make build-frontne râle pas, alors que les fichiers CSS de KaTeX étaient manquants...