Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eviter la superposition de Clem et du message d'accueil (#6400) #6438

Merged
merged 2 commits into from Feb 20, 2023
Merged

Eviter la superposition de Clem et du message d'accueil (#6400) #6438

merged 2 commits into from Feb 20, 2023

Conversation

thibautlanier
Copy link
Contributor

Fix #6400

Contrôle qualité

@Situphen Situphen added this to En développement in Suivi des PR via automation Dec 11, 2022
@Situphen Situphen moved this from En développement to En attente de QA in Suivi des PR Dec 11, 2022
@coveralls
Copy link

coveralls commented Dec 11, 2022 •
edited

Coverage Status

Coverage: 88.31%. Remained the same when pulling e1fb4e7 on thibautlanier:message_accueil into 340ab0d on zestedesavoir:dev.

NaelDeLuca
NaelDeLuca approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@NaelDeLuca NaelDeLuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La modification règle bien le problème: lorsqu'on ajoute un message d'accueil long, le début du message ne passe plus sous Clem.

Suivi des PR automation moved this from En attente de QA to Fusionnable après rebase Feb 20, 2023
@Situphen Situphen enabled auto-merge (squash) February 20, 2023 18:10
@Situphen Situphen merged commit d056227 into zestedesavoir:dev Feb 20, 2023
Suivi des PR automation moved this from Fusionnable après rebase to Fusionnée Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Situphen Situphen Situphen approved these changes

@NaelDeLuca NaelDeLuca NaelDeLuca approved these changes

Assignees
No one assigned
Labels
QA Réservée Projet Étudiants
Projects
Suivi des PR
  
Fusionnée
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Le message d'accueil est en dessous de Clem
4 participants
@thibautlanier @coveralls @Situphen @NaelDeLuca