Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mise à jour des dépendances Node.js #6448

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Mise à jour des dépendances Node.js #6448

merged 1 commit into from
Jan 12, 2023

Conversation

Situphen
Copy link
Member

Mise à jour des dépendances Node.js, sauf Chart.js qui est passé en v4 ainsi que gulp-imagemin et del car ce sont maintenant des ESM (EcmaScript Module) donc il faudrait convertir Gulpfile.js en ESM lui aussi pour que ça fonctionne.

QA :

  • source zdsenv/bin/activate && make update && make zmd-start && make run-back
  • Vérifier que le site web fonctionne correctement, notamment l'éditeur de texte

@Situphen Situphen added the C-Front Concerne l'interface du site label Jan 11, 2023
@Situphen Situphen added this to En développement in Suivi des PR via automation Jan 11, 2023
@coveralls
Copy link

Coverage Status

Coverage: 88.294%. Remained the same when pulling 44425a6 on Situphen:nodejs into 5f6bcab on zestedesavoir:dev.

philippemilink
philippemilink approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

Suivi des PR automation moved this from En développement to Fusionnable après rebase Jan 12, 2023
@philippemilink philippemilink merged commit 3eae855 into zestedesavoir:dev Jan 12, 2023
Suivi des PR automation moved this from Fusionnable après rebase to Fusionnée Jan 12, 2023
@Situphen Situphen deleted the nodejs branch January 12, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
C-Front Concerne l'interface du site
Projects
Suivi des PR
Archived in project
Suivi des PR
  
Fusionnée
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Situphen @coveralls @philippemilink