Optimise certaines requêtes SQL #6490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemilink
force-pushed
the
n+1-sql-queries
branch
2 times, most recently
from
c586ece
to
4ff49bb
Compare
philippemilink
force-pushed
the
n+1-sql-queries
branch
2 times, most recently
from
fbb77dc
to
b8b0e5e
Compare
Arnaud-D
force-pushed
the
n+1-sql-queries
branch
from
73c52e8
to
d17fe42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette série de commits optimise certaines requêtes SQL sur quelques pages, notamment à partir de ce qui a été relevé par Sentry.
Fix #6412, même si de nombreuses N+1 requêtes persistent, notamment à cause de la façon dont notre code est conçu (faire des requêtes SQL dans certains attributs d'objets).
Contrôle qualité
Vérifier que la CI passe, que les pages impactées (elles sont indiquées dans les messages de commits) fonctionnent toujours. Si vous avez le courage de s'assurer que le nombre de requêtes SQL baisse, il faut regarder la debug toolbar et actualiser une fois la page (le menu est mis en cache, ce qui économise beaucoup de requêtes).