Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text fonts: bye bye Google Fonts, welcome npm packages #6607

Merged
merged 2 commits into from Apr 20, 2024
Merged

Text fonts: bye bye Google Fonts, welcome npm packages #6607

merged 2 commits into from Apr 20, 2024

Conversation

Situphen
Copy link
Member

PR liée au sujet sur le forum concernant l'intégration des sources externes

Même principe que mes deux PR précédentes, rien à dire de spécial.

QA :

  • source zdsenv/bin/activate && make update && make zmd-start && make run-back
  • Vérifier qu'aucun appel à Google Fonts n'est effectué depuis les pages du site
  • Vérifier que les différents textes utilisent bien les bonnes polices de caractères

@Situphen Situphen added this to En développement in Suivi des PR via automation Apr 17, 2024
@coveralls
Copy link

coveralls commented Apr 17, 2024 •
edited

Coverage Status

coverage: 88.752%. remained the same
when pulling b428913 on Situphen:google-fonts
into bcf8e53 on zestedesavoir:dev.

@Situphen Situphen moved this from En développement to En attente de QA in Suivi des PR Apr 18, 2024
philippemilink
philippemilink approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@philippemilink philippemilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

Suivi des PR automation moved this from En attente de QA to Fusionnable après rebase Apr 20, 2024
@philippemilink philippemilink merged commit 7b70da3 into zestedesavoir:dev Apr 20, 2024
12 checks passed
Suivi des PR automation moved this from Fusionnable après rebase to Fusionnée Apr 20, 2024
@Situphen Situphen deleted the google-fonts branch April 20, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippemilink philippemilink philippemilink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Suivi des PR
  
Fusionnée
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Situphen @coveralls @philippemilink