zmarkdown escape latex titles

zestedesavoir · Jun 25, 2018 · 201c249 · 201c249
1 parent 54d9279
commit 201c249
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/packages/zmarkdown/__tests__/__snapshots__/server.tests.js.snap b/packages/zmarkdown/__tests__/__snapshots__/server.tests.js.snap
@@ -26,3 +26,23 @@ exports[`Texfile endpoint accepts POSTed markdown 1`] = `
 
 \\\\end{document}"
 `;
+
+exports[`Texfile endpoint escapes title and author 1`] = `
+"\\\\documentclass[contentType]{zmdocument}
+
+\\\\usepackage{blindtext}
+\\\\title{recap \\\\#1}
+\\\\author{titi\\\\_alone}
+\\\\licence[/tmp/l/by-nc-sa.svg]{CC-BY-NC-SA}{https://creativecommons.org/licenses/by-nc-sa/4.0/legalcode}
+
+\\\\smileysPath{/tmp/s}
+\\\\makeglossaries
+
+\\\\begin{document}
+\\\\maketitle
+\\\\tableofcontents
+
+\\\\levelOneTitle{foo}
+
+\\\\end{document}"
+`;
diff --git a/packages/zmarkdown/__tests__/server.tests.js b/packages/zmarkdown/__tests__/server.tests.js
@@ -2,7 +2,7 @@ const clone = require('clone')
 const dedent = require('dedent')
 const a = require('axios')
 const fs = require('fs')
-
+const xtend = require('xtend')
 const u = (path) => `http://localhost:27272${path}`
 const epub = u('/epub')
 const html = u('/html')
@@ -203,6 +203,16 @@ describe('Texfile endpoint', () => {
     expect(metadata).toEqual({})
   })
 
+  it('escapes title and author', async () => {
+    const titleOpts = {authors: ['titi_alone'], title: 'recap #1'}
+    const response = await a.post(texfile,
+      {md: '# foo', opts: xtend(texfileOpts, titleOpts)})
+    expect(response.status).toBe(200)
+
+    const result = response.data
+    expect(result[0]).toMatchSnapshot()
+  })
+
   it('does not return metadata', async () => {
     const response = await a.post(texfile, {md: '# foo', opts: texfileOpts})
 

diff --git a/packages/zmarkdown/templates/latex-document.js b/packages/zmarkdown/templates/latex-document.js
@@ -1,4 +1,5 @@
 const assert = require('assert')
+const escape = require('rebber/dist/escaper')
 
 const template = (opts, callback) => {
   const {
@@ -30,8 +31,8 @@ const template = (opts, callback) => {
   return callback(null, `\\documentclass[${contentType}]{zmdocument}
 
 \\usepackage{blindtext}
-\\title{${title}}
-\\author{${authors.join(', ')}}
+\\title{${escape(title)}}
+\\author{${escape(authors.join(', '))}}
 ${licenseLine}
 
 \\smileysPath{${smileysDirectory}}