Table does not have caption

[AmarOk1412]

Like #66 we need a plugin to embed caption for tables

Example of code:

a | b
----|----
c | d
Table: dummy

+-----+-----+
|  a  |  b  |
+-----+-----+
|  c  |  d  |
+-----+-----+
Table: dummy

[artragis]

They have it, only rebber needs a full plugin for that but it is not so easy.

[AmarOk1412]

I reopen this because of:

+-----+-----+
|  a  |  b  |
+-----+-----+
|  c  |  d  |
+-----+-----+
Table: dummy

[vhf]

Please explain what's wrong :)

[AmarOk1412]

Yeap @vhf I know, but I didn't know what's wrong. I think I understand now!

@artragis Gotcha! https://github.com/zestedesavoir/zmarkdown/blob/master/packages/remark-captions/src/index.js#L17 (Object.keys(legendBlock).forEach(nodeType => visit(tree, nodeType, externLegendVisitorCreator(blocks))))

The plugin only visit nodes in legendBlock, not in blocks so new nodes (like gridTable) in blocks is simply ignored. I think we just have to replace legendBlock by blocks and add a new test (and it will work). If you want to correct this (or I can do this after the ping plugin).

[artragis]

Ok thank you. I fix it quickly.