Start supporting code #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 13, 2017
|
|
||
| const makeExtra = { | ||
| blockquote: node => {}, | ||
| code: node => {language: node.lang, lines: node.hightlighted || ''} |
houndci-bot
reviewed
Jun 13, 2017
| @@ -51,6 +58,38 @@ function visitor (node, index, parent) { | |||
| node.data = figure.data | |||
| } | |||
|
|
|||
| function externLegendVisitor (node, index, parent) { | |||
| if (index + 1 < parent.children.length && parent.children[index + 1].type === 'paragraph' ) { | |||
There was a problem hiding this comment.
There should be no spaces inside this paren space-in-parens
houndci-bot
reviewed
Jun 13, 2017
| @@ -51,6 +58,38 @@ function visitor (node, index, parent) { | |||
| node.data = figure.data | |||
| } | |||
|
|
|||
| function externLegendVisitor (node, index, parent) { | |||
| if (index + 1 < parent.children.length && parent.children[index + 1].type === 'paragraph' ) { | |||
There was a problem hiding this comment.
There should be no spaces inside this paren space-in-parens
artragis
force-pushed
the
codes
branch
3 times, most recently
from
b615d1c
to
cb173f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a matter of fact this aims to implement #66 but I think #67 should be nearly done. I just miss unittest for tables/gridtables.