Add byte spans #102
Merged
Add byte spans #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way LabelInfo doesn't need to depend on the particular impl of Span. This also removes the redundancy in LabelInfo, because labels of the same file are stored in the same SourceGroup anyway. This is in preparation for switching over to byte spans.
Closes zesterer#8 Closes Duplicate issues zesterer#71 and zesterer#57
|
Thanks for the PR! Sorry about the delay in responding, I'm going to try to find time to review this over the next day. |
|
Thanks for the superb PR. Usually with a PR of this length I challenge myself to find at least one problem with it, but I'm at a loss here: all looks good. Thanks again! |
|
Reminder to self: update changelog and bump version |
|
That is quite the compliment! Thank you 😄 |
|
great news, thank you both! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the possibility to use byte spans at the Report level. You can configure using byte spans by calling
I went down a few paths in trying to implement this without API breaks, before settling on making it configurable in the ReportBuilder. Doing it this way allows the user to use the same Span types as before, just with byte indices.
I performed this addition in two steps. Refactoring write.rs to store the computed char span in LabelInfo's
char_span : Range<usize>field everywhere. In the second part I convert the given byte spans to char spans, if the Report's been configured to.