Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In just testing some byte offset to char index conversion code, I noticed
#41
When testing with "馃".
Naively just modifying
char_width()
prints multiple instances of the unicode character in question."馃" becomes "馃馃",
I left this behavior enabled for whitespace since I believe it is a part of the treatment of '\t' tab characters.
This perhaps doesn't fully fix the issue as reported, they might need a boolean to
Config
setting, which sets things up to call eitherwidth
andwidth_cjk
, but I don't know the right behavior to shoot for regarding whitespace in cjk.