Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): adding namespaces back #1228

Merged
merged 7 commits into from
Oct 9, 2023
Merged

fix(rpc): adding namespaces back #1228

merged 7 commits into from
Oct 9, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Oct 3, 2023

Description

Adding debug methods along with other RPC back given the fact that it can be configured in the node config.

@CharlieMc0 do you know if a specific method in a namespace can be disabled in the node config?
We wanted to disable the method from eth namespace:

SendTransaction
Sign
SignTypedData

because those interact with unlocked accounts in the node and therefore have some security concerns.

Closes: #1219

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis requested a review from a team October 3, 2023 01:31
@lumtis lumtis marked this pull request as ready for review October 3, 2023 01:35
@lumtis lumtis self-assigned this Oct 3, 2023
@CharlieMc0
Copy link
Member

Only the namespace can be disabled, not specific methods. It might be okay to keep those methods disabled.

SendTransaction
Sign
SignTypedData

The only complaints we got were around debug.

@lumtis
Copy link
Member Author

lumtis commented Oct 3, 2023

Only the namespace can be disabled, not specific methods. It might be okay to keep those methods disabled.

SendTransaction
Sign
SignTypedData

The only complaints we got were around debug.

Ok, it makes sense to me, the three methods looks for niche purposes to me.

@lumtis lumtis merged commit aaefa00 into develop Oct 9, 2023
13 checks passed
@lumtis lumtis deleted the refactor/add-debug-back branch October 9, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-enable Debug Methods
3 participants