Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicate funtion name IsEthereum #1279

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

lukema95
Copy link
Contributor

@lukema95 lukema95 commented Oct 12, 2023

Description

We already have the function IsEthereumChain that has the same function as IsEthereum, so the duplicate function IsEthereum should be removed.

Closes: #1271

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis changed the title remove duplicate funtion name IsEthereum refactor: remove duplicate funtion name IsEthereum Oct 12, 2023
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the contribution, I see there is a small conflict to resolve

@lukema95
Copy link
Contributor Author

Looking good, thanks for the contribution, I see there is a small conflict to resolve

Conflict resolved

@lumtis lumtis mentioned this pull request Oct 13, 2023
@lumtis
Copy link
Member

lumtis commented Oct 13, 2023

Not sure why this gosec got raised now, created a PR for it #1288

@lumtis lumtis merged commit d31b61c into zeta-chain:develop Oct 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated IsEthereumChain function in common
3 participants