Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fixes to stateful upgrade #1280

Merged
merged 5 commits into from
Oct 16, 2023
Merged

fix: minor fixes to stateful upgrade #1280

merged 5 commits into from
Oct 16, 2023

Conversation

kevinssgh
Copy link
Contributor

Description

  • Increased update block to allow enough time for additional tests to complete.
  • Removed pull cmd since the target version might be a tag.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinssgh kevinssgh merged commit 817cc47 into develop Oct 16, 2023
13 checks passed
@lumtis lumtis deleted the upgrade-test-fixes branch October 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kingpinXD kingpinXD Awaiting requested review from kingpinXD kingpinXD is a code owner

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinssgh @lumtis @ws4charlie