Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query outtx tracker by chain using prefixed store #1283

Merged
merged 7 commits into from
Oct 14, 2023
Merged

fix: query outtx tracker by chain using prefixed store #1283

merged 7 commits into from
Oct 14, 2023

Conversation

ws4charlie
Copy link
Contributor

@ws4charlie ws4charlie commented Oct 12, 2023 •
edited

Description

The RPC OutTxTrackerAllByChain is not strictly iterating over chainID-prefixed store which caused query problem before
in zetaclient.

Closes: <1274>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@lumtis lumtis linked an issue Oct 12, 2023 that may be closed by this pull request
out tx tracker query by chain should iterate with prefix of chain id #1274
Closed
kevinssgh
kevinssgh approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@kevinssgh kevinssgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ws4charlie ws4charlie merged commit fb82095 into develop Oct 14, 2023
13 checks passed
@ws4charlie ws4charlie deleted the fix-outtx-tracker-query-by-chain branch October 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@kevinssgh kevinssgh kevinssgh approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

out tx tracker query by chain should iterate with prefix of chain id
4 participants
@ws4charlie @lumtis @kingpinXD @kevinssgh