Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate builds #1391

Closed
wants to merge 39 commits into from
Closed

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Nov 13, 2023

Description

WIP

Closes: #1331

Copy link

github-actions bot commented Nov 14, 2023

!!!WARNING!!!
nosec detected in the following files: contrib/localnet/orchestrator/smoketest/main.go, contrib/localnet/orchestrator/smoketest/test_accounting.go, contrib/localnet/orchestrator/smoketest/test_bitcoin.go, contrib/localnet/orchestrator/smoketest/test_deposit_eth.go, contrib/localnet/orchestrator/smoketest/test_stress.go, contrib/localnet/orchestrator/smoketest/test_update_bytecode.go, contrib/localnet/orchestrator/smoketest/test_zeta_in_and_out.go, contrib/rpctest/main.go, rpc/namespaces/ethereum/debug/api.go, rpc/namespaces/ethereum/debug/trace.go, rpc/namespaces/ethereum/debug/utils.go, rpc/websockets.go, server/start.go, testutil/network/util.go, x/observer/module_simulation.go, zetaclient/bitcoin_client.go, zetaclient/inbound_tracker.go, zetaclient/config/config_chain.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Nov 14, 2023
@lumtis lumtis self-assigned this Nov 14, 2023
@lumtis lumtis closed this Dec 5, 2023
This was referenced Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate builds - reduce number of binaries
1 participant