Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename aux.go => utils.go to avoid go package resolver complaint #1446

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

brewmaster012
Copy link
Collaborator

@brewmaster012 brewmaster012 commented Dec 19, 2023

Description

because of error importing this project

go: loading module retractions for github.com/zeta-chain/node@v1.2.1: verifying go.mod: github.com/zeta-chain/node@v1.2.1/go.mod: reading https://sum.golang.org/lookup/github.com/zeta-chain/node@v1.2.1: 404 Not Found
	server response: not found: create zip: cmd/zetaclientd/aux.go: malformed file path "cmd/zetaclientd/aux.go": "aux" disallowed as path element component on Windows

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

because of error importing this project
```
go: loading module retractions for github.com/zeta-chain/node@v1.2.1: verifying go.mod: github.com/zeta-chain/node@v1.2.1/go.mod: reading https://sum.golang.org/lookup/github.com/zeta-chain/node@v1.2.1: 404 Not Found
	server response: not found: create zip: cmd/zetaclientd/aux.go: malformed file path "cmd/zetaclientd/aux.go": "aux" disallowed as path element component on Windows
```
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not very conventional to end file with underscore. Can we maybe instead rename the file utils.go?

changelog.md Outdated Show resolved Hide resolved
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@brewmaster012 brewmaster012 changed the title fix: rename aux.go => aux_.go fix: rename aux.go => utils.go to avoid go package resolver complaint Dec 27, 2023
@lumtis lumtis merged commit 905e13d into develop Jan 3, 2024
15 checks passed
@lumtis lumtis deleted the fix-aux-filename branch January 3, 2024 17:29
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants