Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gov proposal scripts to localnet to support fronend development #1499

Merged
merged 11 commits into from
Jan 3, 2024

Conversation

CharlieMc0
Copy link
Member

Description

Creates a localnet_gov_admin on the host system and creates a governance proposals in a variety of states. Rejected, Approved, Pending Deposit, Pending Vote, etc and increases the proposal window to one hour which helps frontend developers who need to consume the proposal data in pending states.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this locally and it works. It makes not change changes to the smoke tests themselves besides adding a new genesis account into the localnet environment.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

CharlieMc0 and others added 2 commits December 22, 2023 08:07
Co-authored-by: Hernan Clich <62221379+hernan-clich@users.noreply.github.com>
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
In the future, I think it would be better to move the proposal creations in the zeta_tx_server package in orchestrator module for more programmability and flexibility. And so we could have a --with-gov-proposals flag when starting the localnet.

But fine like this if this unblock devs

@CharlieMc0
Copy link
Member Author

Looks good to me. In the future, I think it would be better to move the proposal creations in the zeta_tx_server package in orchestrator module for more programmability and flexibility. And so we could have a --with-gov-proposals flag when starting the localnet.

But fine like this if this unblock devs

Thanks this is helpful to know. I was thinking about how it could be part of the smoke test and though about trying to write it in Go but wanted to get something out ASAP to help out the front end devs.

@lumtis lumtis merged commit 059f0a6 into develop Jan 3, 2024
15 checks passed
@lumtis lumtis deleted the localnet-gov-proposals branch January 3, 2024 08:54
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants