fix: relax header length basic check #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSC network may have larger header "error":"/zetachain.zetacore.observer.MsgAddBlockHeader invalid msg | invalid block header (header too long (2223)): invalid request
brewmaster012
requested review from
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
lumtis
approved these changes
Jan 4, 2024
ws4charlie
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
4096 looks good according to a thread: https://ethereum.stackexchange.com/questions/13017/how-large-are-the-ethereum-block-headers
kingpinXD
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BSC network may have larger header
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: