Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pending nonces genesis import #1546

Merged
merged 9 commits into from
Jan 12, 2024
Merged

fix: pending nonces genesis import #1546

merged 9 commits into from
Jan 12, 2024

Conversation

kingpinXD
Copy link
Contributor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments

x/crosschain/client/integrationtests/inbound_voter_test.go Outdated Show resolved Hide resolved
x/observer/genesis.go Outdated Show resolved Hide resolved
ws4charlie
ws4charlie approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. left minor comment

@lumtis lumtis linked an issue Jan 11, 2024 that may be closed by this pull request
zetaocored : Add genesis import and export for all state date #1471
Closed
@lumtis lumtis added this to the v12 milestone Jan 11, 2024
@kingpinXD kingpinXD merged commit c657669 into develop Jan 12, 2024
15 checks passed
@kingpinXD kingpinXD deleted the add-missing-genesis branch January 12, 2024 15:55
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
breaking:cli
Projects
None yet
Milestone
v12
Development

Successfully merging this pull request may close these issues.

zetaocored : Add genesis import and export for all state date
3 participants
@kingpinXD @lumtis @ws4charlie