Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: screen out unconfirmed utxos that are not created by TSS itself #1554

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fix: screen out unconfirmed utxos that are not created by TSS itself #1554

merged 3 commits into from
Jan 11, 2024

Conversation

ws4charlie
Copy link
Contributor

Description

  • Screen out unconfirmed UTXOs that are not created by TSS to prevent DoS.

Closes: 48

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@ws4charlie ws4charlie added the audit Fixes for issues found in audit label Jan 11, 2024
@ws4charlie ws4charlie added the zetaclient Issues related to ZetaClient label Jan 11, 2024
lumtis
lumtis approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis added this to the v12 milestone Jan 11, 2024
@ws4charlie ws4charlie merged commit c388606 into develop Jan 11, 2024
15 checks passed
@ws4charlie ws4charlie deleted the fix-btc-unconfirmed-UTXO-DoS branch January 11, 2024 22:13
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
audit Fixes for issues found in audit zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
v12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ws4charlie @lumtis @kingpinXD