Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): reduce websocket message limit to 10MB #1555

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fix(rpc): reduce websocket message limit to 10MB #1555

merged 3 commits into from
Jan 11, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Jan 11, 2024

@lumtis lumtis changed the title fix(): reduce websocket message limit to 10MB fix(rpc): reduce websocket message limit to 10MB Jan 11, 2024
kingpinXD
kingpinXD approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ,
We should consider some testing with the consumers of the websocket though , to see if it affects them by any chance ?

@lumtis
Copy link
Member Author

lumtis commented Jan 11, 2024

to see if it affects them by any chance ?
Very unlikely I think, we were using a very high value, 10MB is the regular limit

@lumtis lumtis added this to the v12 milestone Jan 11, 2024
ws4charlie
ws4charlie approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me if GoLang accepts 10MB by default on the HTTP service

@lumtis lumtis merged commit a9c613b into develop Jan 11, 2024
15 checks passed
@lumtis lumtis deleted the fix/websocket-size branch January 11, 2024 20:59
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD approved these changes

@ws4charlie ws4charlie ws4charlie approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lumtis @kingpinXD @ws4charlie