Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add chain id to get tss address rpc #1567

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Jan 11, 2024

Description

add option chain id to get-tss-address rpc .

Closes: #1502

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title add chain id to rpc fix: add chain id to get tss address rpc Jan 11, 2024
@kingpinXD kingpinXD marked this pull request as ready for review January 11, 2024 20:50
@brewmaster012
Copy link
Collaborator

how was this tested?

@kingpinXD
Copy link
Contributor Author

kingpinXD commented Jan 12, 2024

how was this tested?

just localhost
image
image
image

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we just add an entry in Breaking Changes in Changelogs?

@kingpinXD kingpinXD merged commit b3b608d into develop Jan 12, 2024
15 checks passed
@kingpinXD kingpinXD deleted the fix-gettssaddress-rpc branch January 12, 2024 03:18
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: rpc: zeta-chain/crosschain/get_tss_address returns wrong btc network address
4 participants