-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix the cleanup step in the rc-release and publish-release pipelines #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzukel
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
January 13, 2024 02:18
lumtis
reviewed
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can rename fix
to ci
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
billyyang423
approved these changes
Jan 13, 2024
CharlieMc0
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from DevOps. Timing for merging and change log refer to @lumtis
julianrubino
approved these changes
Jan 15, 2024
lumtis
approved these changes
Jan 15, 2024
lumtis
reviewed
Jan 16, 2024
lumtis
changed the title
fix: fix the cleanup step in the rc-release and publish-release pipelines
ci: fix the cleanup step in the rc-release and publish-release pipelines
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: fix the cleanup step in the rc-release and publish-release pipelines
Closes: No-Ticket-Adhoc-Fix
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: