Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the cleanup step in the rc-release and publish-release pipelines #1580

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

gzukel
Copy link
Collaborator

@gzukel gzukel commented Jan 13, 2024

Description

fix: fix the cleanup step in the rc-release and publish-release pipelines

Closes: No-Ticket-Adhoc-Fix

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gzukel gzukel requested a review from a team as a code owner January 13, 2024 02:17
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jan 13, 2024
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can rename fix to ci

.github/workflows/rc-release.yml Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from DevOps. Timing for merging and change log refer to @lumtis

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@lumtis lumtis changed the title fix: fix the cleanup step in the rc-release and publish-release pipelines ci: fix the cleanup step in the rc-release and publish-release pipelines Jan 21, 2024
@lumtis lumtis merged commit e06711b into develop Jan 21, 2024
18 of 21 checks passed
@lumtis lumtis deleted the fix-cleanup-step branch January 21, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants