Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keygen migration script #1632

Merged
merged 6 commits into from
Jan 25, 2024
Merged

feat: Keygen migration script #1632

merged 6 commits into from
Jan 25, 2024

Conversation

kingpinXD
Copy link
Contributor

@kingpinXD kingpinXD commented Jan 24, 2024 •
edited

Description

Add a migration script to set status to KeyGenSuccess if its in Pending Status

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

lumtis
lumtis reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been tested with make stateful-upgrade-source?

app/setup_handlers.go Show resolved Hide resolved
lumtis
lumtis approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok the migration script is triggered with upgrade test

@lumtis lumtis merged commit d1236ba into develop Jan 25, 2024
15 checks passed
@lumtis lumtis deleted the keygen-migration-script branch January 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kingpinXD @lumtis @brewmaster012