Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: zetaclient re-organization #1640

Merged
merged 18 commits into from
Feb 12, 2024
Merged

refactor: zetaclient re-organization #1640

merged 18 commits into from
Feb 12, 2024

Conversation

kevinssgh
Copy link
Contributor

@kevinssgh kevinssgh commented Jan 25, 2024

Description

Organize zetaclient source code.

Closes: (#1607)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

github-actions bot commented Jan 25, 2024

!!!WARNING!!!
nosec detected in the following files: zetaclient/bitcoin/inbound_tracker.go, zetaclient/bitcoin/utils.go, zetaclient/bitcoin/bitcoin_client.go, zetaclient/bitcoin/bitcoin_signer.go, zetaclient/bitcoin/bitcoin_signer_test.go, zetaclient/evm/evm_client.go, zetaclient/evm/evm_signer.go, zetaclient/keys/keys_test.go, zetaclient/tss/tss_signer.go, zetaclient/zetabridge/broadcast.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Jan 25, 2024
@kevinssgh kevinssgh marked this pull request as ready for review January 30, 2024 20:16
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, some comment

zetaclient/bitcoin/btc_signer.go Outdated Show resolved Hide resolved
zetaclient/evm/utils.go Outdated Show resolved Hide resolved
zetaclient/klaytn/klaytn_client.go Outdated Show resolved Hide resolved
@kevinssgh kevinssgh requested a review from lumtis February 7, 2024 16:09
changelog.md Outdated Show resolved Hide resolved
cmd/zetaclientd/debug.go Outdated Show resolved Hide resolved
contrib/localnet/orchestrator/smoketest/runner/bitcoin.go Outdated Show resolved Hide resolved
zetaclient/keys/keys.go Outdated Show resolved Hide resolved
zetaclient/keys/keys.go Outdated Show resolved Hide resolved
zetaclient/outtxprocessor/out_tx_processor_manager.go Outdated Show resolved Hide resolved
zetaclient/tss/tss_signer.go Outdated Show resolved Hide resolved
zetaclient/zetasupplychecker/zeta_supply_checker.go Outdated Show resolved Hide resolved
@kevinssgh kevinssgh requested a review from lumtis February 7, 2024 21:09
@lumtis
Copy link
Member

lumtis commented Feb 11, 2024

@kevinssgh I think we can solve these conflicts then merge

@lumtis lumtis mentioned this pull request Feb 12, 2024
5 tasks
@lumtis lumtis linked an issue Feb 12, 2024 that may be closed by this pull request
@kevinssgh kevinssgh merged commit ae22f1e into develop Feb 12, 2024
21 checks passed
@kevinssgh kevinssgh deleted the zetaclient-refactor1 branch February 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more organization in the package structuring of ZetaClient
3 participants