Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change WhitelistERC20 authorization from group1=>group2 #1642

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix: change WhitelistERC20 authorization from group1=>group2 #1642

merged 4 commits into from
Jan 29, 2024

Conversation

brewmaster012
Copy link
Collaborator

@brewmaster012 brewmaster012 commented Jan 26, 2024 •
edited

Description

Whitelisting ERC20 should be authorized to group2 only.

Closes: #1641

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis mentioned this pull request Jan 26, 2024
Open
lumtis
lumtis reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test should fail if change the group, created an issue for this: #1644

changelog.md Show resolved Hide resolved
lumtis
lumtis approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving if the changelog can be fixed

@lumtis lumtis merged commit 1c97d9f into develop Jan 29, 2024
15 checks passed
@lumtis lumtis deleted the fix-erc20whitelist-to-group2 branch January 29, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change MsgWhitelistERC20 authorization from group1 to group2
3 participants
@brewmaster012 @lumtis @kingpinXD